Skip to content

feat: add WsAllowOutOfOrder config#68

Merged
calvwang9 merged 5 commits intov2-previewfrom
feat/ws-allow-out-of-order
Apr 16, 2026
Merged

feat: add WsAllowOutOfOrder config#68
calvwang9 merged 5 commits intov2-previewfrom
feat/ws-allow-out-of-order

Conversation

@calvwang9
Copy link
Copy Markdown

add new config WsAllowOutOfOrder to all SDKs, default false.

this allows the client exporter to filter out HF report gaps resulting from out-of-order reports

@calvwang9 calvwang9 requested a review from a team as a code owner April 9, 2026 05:10
@calvwang9 calvwang9 requested review from JoshC2k, akuzni2 and ro-tex April 9, 2026 05:10
Comment thread go/README.md
Comment thread go/stream.go Outdated
Comment on lines +168 to +169
// todo: this assumes that the timestamp is in seconds, introduce millisecond support when sdk is
// updated to handle millisecond timestamps.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're merging this into v2-preview. I think you can already start using the milliseconds timestamp.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ms timestamp and v2 hf support in general havent been added to the ts and rust sdks, only go

@ro-tex ro-tex self-requested a review April 13, 2026 12:27
Comment thread go/dedup.go
Comment thread go/dedup.go
Comment thread typescript/src/stream/deduplication.ts Outdated
Comment thread rust/crates/sdk/src/stream/dedup.rs Outdated
Copy link
Copy Markdown
Contributor

@ro-tex ro-tex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calvwang9 calvwang9 merged commit 4c210b9 into v2-preview Apr 16, 2026
1 check passed
@calvwang9 calvwang9 deleted the feat/ws-allow-out-of-order branch April 16, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants